Skip to content

build: link LLVMCoverage some more #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented May 5, 2016

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

These tests seem to link against libraries needing LLVMCoverage. This fixes the
dependency.

These tests seem to link against libraries needing LLVMCoverage.  This fixes the
dependency.
@compnerd
Copy link
Member Author

compnerd commented May 5, 2016

CC @rudkx

@rudkx
Copy link
Contributor

rudkx commented May 5, 2016

Are you seeing a build failure under some configuration without these changes?

I am able to build successfully without these, and it doesn't look like SILGen/IRGen are used by either of these, which I believe is how we end up pulling in the dependency on LLVMCoverage.

@compnerd
Copy link
Member Author

compnerd commented May 5, 2016

Yeah, I was seeing build failures under the debug configuration. (Ill try a clean build in a little while)

@rudkx rudkx self-assigned this May 5, 2016
@rudkx
Copy link
Contributor

rudkx commented May 7, 2016

Can you try building with 859b779 applied?

I see no linker errors on OS X with that patch, but still have four errors on Linux, which I believe are due to a difference in the way the Linux linker works.

I also committed ff25872, which resolves two of the Linux issues, but this is really just a hack that happens to work in some cases. I am looking for a more principled approach to fixing the issues there.

@rudkx rudkx closed this May 7, 2016
@compnerd compnerd deleted the coverage-linkage branch July 3, 2016 17:11
MaxDesiatov pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants