Add Std Handle Values to WinSDK #24148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if I have CI privileges yet: @swift-ci please test |
compnerd
requested changes
Apr 18, 2019
stdlib/public/Windows/WinSDK.swift
Outdated
| // ProcessEnv.h | ||
| public let STD_INPUT_HANDLE: DWORD = DWORD(bitPattern: -10) | ||
| public let STD_OUTPUT_HANDLE: DWORD = DWORD(bitPattern: -11) | ||
| public let STD_ERROR_HANDLE: DWORD = DWORD(bitPattern: -12) |
There was a problem hiding this comment.
These are from WinBase.h. Please move them along with the other WinBase.h constants.
There was a problem hiding this comment.
Alright, updated to indicate they're from WinBase.h
Added the values of STD_*_HANDLE to WinSDK for use with GetStdHandle
compnerd
approved these changes
Apr 19, 2019
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the values of STD_*_HANDLE to WinSDK for use with GetStdHandle since otherwise swift complains about storing a negative number in a UInt32. See: https://docs.microsoft.com/en-us/windows/console/getstdhandle