[stdlib] _BridgedStoredNSError should conform to CustomStringConvertible #24149
Conversation
Since it is a struct that wraps an NSError, it should map its `description` property to its internal NSError instance
colemancda
changed the title
_BridgedStoredNSError should conform to CustomStringConvertible
colemancda
changed the title
|
@compnerd please test |
| @@ -433,6 +433,12 @@ public protocol _BridgedStoredNSError : | |||
| init(_nsError error: NSError) | |||
| } | |||
|
|
|||
| public extension _BridgedStoredNSError { | |||
There was a problem hiding this comment.
Mind moving the conformance here?
There was a problem hiding this comment.
I cannot due to compiler error, please check swiftlang/swift-corelibs-foundation#2140 (comment)
|
CC: @millenomi |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
The CI is buggy, it reports a failure but then clearly shows that it has identified 0 issues. |
|
@compnerd Can we marge without the macOS CI passing? The error only displays "No test results found.". I've also reviewed the console output and found no compilation error. |
There was a problem hiding this comment.
I'm pretty sure this is ABI breaking and won't fly. Even though _BridgedNSError is underscored, it's public. Even if we're willing to break the ABI for underscored things (and we probably aren't), adding this conformance transitively adds it to public non-underscored types such as CocoaError, something we can't do post-ABI stability.
No, we cannot. |
|
Not sure why CI's not showing it properly, but the failure is in the console log. Looks like the failing test is https://github.com/apple/swift/blob/master/test/Runtime/demangleToMetadataObjC.swift#L101-L109 which is related to |
|
I can fix the unit test, but if we can't do this because of ABI stability, then there is no point then. |
|
Yes, unfortunately this is an ABI break. I'm going to close this out due to age and inactivity. Thank you for all your efforts thus far. |
Since it is a struct that wraps an NSError, it should map its
descriptionproperty to its internalNSErrorinstance.e.g.
"\(POSIXError(.E2BIG))"Before:
POSIXError(_nsError: Error Domain=NSPOSIXErrorDomain Code=7 "Argument list too long")Now:
Error Domain=NSPOSIXErrorDomain Code=7 "Argument list too long"