-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.1][ParseableInterfaces] Support inheriting default arguments in module interfaces via '= super' #24155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1][ParseableInterfaces] Support inheriting default arguments in module interfaces via '= super' #24155
Conversation
@swift-ci please test |
Build failed |
Build failed |
…n decl in module interfaces
…eters with an inherited default argument to using '= super'
96f9de6
to
d67b4f5
Compare
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
Linux failure seems unrelated:
|
@swift-ci please test Linux |
…a module interface
…interfaces Also: - additionally require the containing and overridden initializers are designated, as that's the only case in which we should produce the '= super' syntax in module interfaces - Add notes to point out the locations of the overriden initializer when it's not designated, and the corresponding parameter in that initializer when it doesn't have a default argument to inherit.
… an execution test Also pass the decls themselves rather than their locations when diagnosing incorrect usage of '= super'.
…n the inherited-defaults-execution.swift test Resolves rdar://problem/50050902
f4dd460
to
7df3e8a
Compare
@swift-ci test and merge |
Build failed |
@swift-ci test and merge |
Cherry-pick of #24073 for swift-5.1-branch
Resolves rdar://49789274