Skip to content

[5.1][ParseableInterfaces] Support inheriting default arguments in module interfaces via '= super' #24155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nathawes
Copy link
Contributor

Cherry-pick of #24073 for swift-5.1-branch

Resolves rdar://49789274

@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96f9de62bd6255205de0973b34615e3ddb8fd9f4

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96f9de62bd6255205de0973b34615e3ddb8fd9f4

@nathawes nathawes force-pushed the module-interface-inherit-default-args-via-super branch from 96f9de6 to d67b4f5 Compare April 19, 2019 17:16
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96f9de62bd6255205de0973b34615e3ddb8fd9f4

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96f9de62bd6255205de0973b34615e3ddb8fd9f4

@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d67b4f5ee68a8a3f9c1ff06a33078f40b452e712

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d67b4f5ee68a8a3f9c1ff06a33078f40b452e712

@nathawes
Copy link
Contributor Author

Linux failure seems unrelated:

.../swift-corelibs-foundation/Foundation/DispatchData+DataProtocol.swift:14:8:
  error: cannot load underlying module for 'Dispatch'

@nathawes
Copy link
Contributor Author

@swift-ci please test Linux

Nathan Hawes added 4 commits April 19, 2019 12:44
…interfaces

Also:
- additionally require the containing and overridden initializers are
  designated, as that's the only case in which we should produce the '= super'
  syntax in module interfaces
- Add notes to point out the locations of the overriden initializer when it's
  not designated, and the corresponding parameter in that initializer when it
  doesn't have a default argument to inherit.
… an execution test

Also pass the decls themselves rather than their locations when diagnosing
incorrect usage of '= super'.
…n the inherited-defaults-execution.swift test

Resolves rdar://problem/50050902
@nathawes nathawes force-pushed the module-interface-inherit-default-args-via-super branch from f4dd460 to 7df3e8a Compare April 19, 2019 19:45
@nathawes
Copy link
Contributor Author

@swift-ci test and merge

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f4dd460a5909806b54d175f8a0cb37a73197e05b

@nathawes
Copy link
Contributor Author

@swift-ci test and merge

@swift-ci swift-ci merged commit 8ea5759 into swiftlang:swift-5.1-branch Apr 19, 2019
@nathawes nathawes deleted the module-interface-inherit-default-args-via-super branch April 19, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants