Always diagnose request evaluator cycles #24213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFC for now, but this problem causes some tests to fail once we enable cycle diagnostics.
If there are no braces, the start and end location of the range is the same token. When performing a lookup at this token's location, don't consider it to be "inside" the braces. NFC for now, but this problem causes some tests to fail once we enable cycle diagnostics.
This comment has been minimized.
This comment has been minimized.
slavapestov
force-pushed
the
diagnose-cycles
branch
from
c3084ad to
713816a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If there are no braces, the start and end location of the range is the same token, so don't create a TypeOrExtensionBody scope at all. NFC for now, but this problem causes some tests to fail once we enable cycle diagnostics.
slavapestov
force-pushed
the
diagnose-cycles
branch
from
713816a to
3f5a06b
Compare
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility |
beccadax
reviewed
Apr 23, 2019
| @@ -1886,8 +1890,7 @@ bool swift::fixDeclarationObjCName(InFlightDiagnostic &diag, ValueDecl *decl, | |||
| return false; | |||
| } | |||
|
|
|||
| // Determine the Objective-C name of the declaration. | |||
| ObjCSelector name = *decl->getObjCRuntimeName(); | |||
| auto name = *nameOpt; | |||
| auto targetName = *targetNameOpt; | |||
There was a problem hiding this comment.
I was a little confused by these two lines when I read them. I guess the idea is that these should only be None when the declaration is implicit or a subscript? If so, maybe there should be a comment here or a sentence in the doc comment to that effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out only minor fixes were needed, so let's enable this and make sure we don't regress.