Skip to content

Re-enable DI test that uses ObjCBool #24214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

Re-enable DI test that uses ObjCBool #24214

merged 1 commit into from
Apr 23, 2019

Conversation

jrose-apple
Copy link
Contributor

Disabled in #24060 because my SIL test was too specific for @Catfish-Man's ObjCBool changes in #23802.

rdar://problem/49942212

@jrose-apple
Re-enable DI test that uses ObjCBool
a8a4f97 
Disabled in c1a21d2 because my SIL test was too specific for
DavidS's ObjCBool changes.

rdar://problem/49942212
@jrose-apple
Copy link
Contributor Author

The original problem was on newer Apple ABIs only (those where BOOL is _Bool), so

@swift-ci Please test

Catfish-Man
Catfish-Man approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the extent that my review is useful on a SIL test, looks good

@jrose-apple jrose-apple merged commit db0b802 into swiftlang:master Apr 23, 2019
@jrose-apple jrose-apple deleted the bool-market branch April 23, 2019 22:32
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request May 9, 2019
@jrose-apple @Catfish-Man
Re-enable DI test that uses ObjCBool (swiftlang#24214)
4b5988c 
Disabled in c1a21d2 because my SIL test was too specific for
DavidS's ObjCBool changes.

rdar://problem/49942212
(cherry picked from commit db0b802)
Catfish-Man added a commit to Catfish-Man/swift that referenced this pull request May 9, 2019
@Catfish-Man
Revert "Re-enable DI test that uses ObjCBool (swiftlang#24214)"
cf3ff05 
This reverts commit 4b5988c.
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request May 9, 2019
@jrose-apple @Catfish-Man
Re-enable DI test that uses ObjCBool (swiftlang#24214)
f0a3e6e 
Disabled in c1a21d2 because my SIL test was too specific for
DavidS's ObjCBool changes.

rdar://problem/49942212
(cherry picked from commit db0b802)
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request May 9, 2019
@jrose-apple @Catfish-Man
Re-enable DI test that uses ObjCBool (swiftlang#24214)
4026a48 
Disabled in c1a21d2 because my SIL test was too specific for
DavidS's ObjCBool changes.

rdar://problem/49942212
(cherry picked from commit db0b802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Catfish-Man Catfish-Man Catfish-Man approved these changes

@atrick atrick Awaiting requested review from atrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @Catfish-Man