[ConstraintSystem] Type of key path expression should be a known KeyPath type
#24234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
…Path` type Currently `getPotentialBindingsForRelationalConstraint` doesn't respect the fact that type of key path expression has to be a form of `KeyPath`, instead it could eagerly try to bind it to `Any` or other contextual type if it's only available information. This patch aims to fix this situation by filtering potential bindings available for type variable representing type of the key path expression. Resolves: SR-10467
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test source compatibility |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
getPotentialBindingsForRelationalConstraintdoesn'trespect the fact that type of key path expression has to be a
form of
KeyPath, instead it could eagerly try to bind it toAnyor other contextual type if it's only availableinformation.
This patch aims to fix this situation by filtering potential
bindings available for type variable representing type of
the key path expression.
Resolves SR-10467.