References to _swift_FORCE_LOAD* symbols should be weak #24242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Swift always copied the overlay dylibs into app bundles, it was OK for these symbol references to be non-weak, but with the overlays now part of the OS on Apple platforms, we need to handle backward deployment scenarios where a new overlay does not exist on an old OS version. A weak reference will serve to pull in the overlay dylib if it exists, without causing a fatal error if it does not. rdar://problem/50110036
|
@swift-ci please test |
jrose-apple
approved these changes
Apr 24, 2019
This was referenced Apr 25, 2019
|
This breaks the windows build! https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=1686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Swift always copied the overlay dylibs into app bundles, it was OK
for these symbol references to be non-weak, but with the overlays now
part of the OS on Apple platforms, we need to handle backward deployment
scenarios where a new overlay does not exist on an old OS version.
A weak reference will serve to pull in the overlay dylib if it exists,
without causing a fatal error if it does not. rdar://problem/50110036