Skip to content

[benchmark] Documentation for legacyFactor #24307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2019
Merged

[benchmark] Documentation for legacyFactor #24307

merged 1 commit into from
Apr 29, 2019
+15 −0

Conversation

palimondo
Copy link
Contributor

Properly document the legacyFactor on BenchmarkInfo, trying to prevent its ritualistic misuse.
cc @atrick, @eeckstein, @gottesmm

@palimondo
Copy link
Contributor Author

@swift-ci smoke test and merge

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

gottesmm
gottesmm approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough for me. I think it could be phrased slightly better but the information is at least there, which is good.

@atrick
Copy link
Contributor

atrick commented Apr 26, 2019

@palimondo Great! Thanks!

@palimondo
Copy link
Contributor Author

@swift-ci smoke test and merge

1 similar comment
@palimondo
Copy link
Contributor Author

@swift-ci smoke test and merge

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@palimondo palimondo merged commit ea80003 into swiftlang:master Apr 29, 2019
@palimondo palimondo deleted the legacy-factor-doc branch April 29, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm gottesmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palimondo @atrick @gottesmm