[CMake] Switch to building the overlays in Swift 5 mode #24350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that that's stabilized, we don't have to keep them in Swift 4 mode any longer. (Arguably we don't need the CMake variable at all, but it may be useful again in the future.) rdar://problem/49040980
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
Rostepher
approved these changes
Apr 28, 2019
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
moiseev
approved these changes
Apr 29, 2019
|
@swift-ci Please test Linux |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Apr 30, 2019
) Now that that's stabilized, we don't have to keep them in Swift 4 mode any longer. (Arguably we don't need the CMake variable at all, but it may be useful again in the future.) rdar://problem/49040980 (cherry picked from commit d20a7ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that that's stabilized, we don't have to keep them in Swift 4 mode any longer. (Arguably we don't need the CMake variable at all, but it may be useful again in the future.)
rdar://problem/49040980