[Build System: CMake] Convert the SWIFT_STDLIB_BUILD_TYPE variable into a CMake cache variable in cmake/modules/StandaloneOverlay.cmake #24352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a CMake cache variable in cmake/modules/StandaloneOverlay.cmake
|
@swift-ci please smoke test |
This was referenced Apr 28, 2019
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please smoke test Linux platform |
compnerd
reviewed
Apr 29, 2019
| @@ -10,9 +10,13 @@ endif() | |||
|
|
|||
| set(CMAKE_INSTALL_PREFIX "${SWIFT_DEST_ROOT}${TOOLCHAIN_DIR}/usr") | |||
|
|
|||
| set(SWIFT_STDLIB_BUILD_TYPE "Release" CACHE STRING | |||
| "Build type for the Swift standard library and SDK overlays [Debug, RelWithDebInfo, Release, MinSizeRel]") | |||
| set_property(CACHE SWIFT_STDLIB_BUILD_TYPE PROPERTY | |||
There was a problem hiding this comment.
Why the property? The set(...CACHE...) should be sufficient.
There was a problem hiding this comment.
I'm just duplicating what's already in the top-level CMakeLists.txt file here.
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.