Skip to content

[android] Remove parts of the build process which are not Android. #24359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drodriguez
Copy link
Contributor

At the moment, the only piece build for Android with the build-script
is the standard library for Swift. This changes the Android CI presets
to skip the later parts of the build-script which only build for the
host machine, saving time and random errors.

@drodriguez drodriguez requested a review from compnerd April 29, 2019 01:18
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libdispatch/foundation are part of the target, not the host. Can you please add a comment explaining that they are disabled because we do not correctly cross-compile them right now? LGTM otherwise

At the moment, the only pieces build for Android with the build-script
is the standard library for Swift. This changes the Android CI presets
to skip the later parts of the build-script which only build for the
host machine, saving time and random errors.
@drodriguez drodriguez force-pushed the android-do-not-build-unnecessary branch from 218b8a0 to 5701edd Compare April 29, 2019 20:43
@drodriguez
Copy link
Contributor Author

Added the comment about why disable the products and a note about Foundation/libdispatch.

@swift-ci please smoke test

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test linux platform

@drodriguez drodriguez merged commit adf224b into swiftlang:master May 1, 2019
@drodriguez drodriguez deleted the android-do-not-build-unnecessary branch May 1, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants