Centralize the definition of isMemberwiseInitialized() #24363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This utility was defined in Sema, used in Sema and Index, declared in two headers, and semi- copy-pasted into SILGen. Pull it into VarDecl::isMemberwiseInitialized() and use it consistently.
|
@swift-ci please smoke test and merge |
…eclared The determination of whether a property is memberwise-initialized is somewhat confused for properties that have synthesized backing properties. Some clients (Sema/Index) want to see the declared properties, while others (SILGen) want to see the backing stored properties. Add a flag to `VarDecl::isMemberwiseInitialized()` to capture this variation.
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility was defined in Sema, used in Sema and Index, declared in
two headers, and semi- copy-pasted into SILGen. Pull it into
VarDecl::isMemberwiseInitialized()and use it consistently.