Skip to content

[benchmark] Breadcrumbs: swap PRNG implementations #24367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

palimondo
Copy link
Contributor

Replaced local LCRNG implementation with SplitMix64 from TestUtils.

Replaced local LCRNG implementation with SplitMix64 from TestUtils.
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Code size: -O

TEST OLD NEW DELTA RATIO
Improvement
Breadcrumbs.o 45701 45221 -1.1% 1.01x

Code size: -Osize

TEST OLD NEW DELTA RATIO
Improvement
Breadcrumbs.o 45214 43662 -3.4% 1.04x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@swift-ci please test Linux platform

@palimondo
Copy link
Contributor Author

Ups. Forgot to type smoke… 💨

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 28adf81

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@palimondo palimondo merged commit 63aa6fb into swiftlang:master Apr 30, 2019
@palimondo palimondo deleted the breadcrumbs-prng-swap branch May 3, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants