EscapeAnalysis: handle SILUndef values #24372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a crash rdar://problem/50279857
|
@swift-ci smoke test and merge |
gottesmm
reviewed
Apr 29, 2019
| @@ -1070,6 +1070,11 @@ static bool mayContainReference(SILType Ty, const SILFunction &F) { | |||
|
|
|||
| bool EscapeAnalysis::isPointer(ValueBase *V) { | |||
| auto *F = V->getFunction(); | |||
|
|
|||
| // The function can be null, e.g. if V is an undef. | |||
| if (!F) | |||
There was a problem hiding this comment.
Is it possible for this to happen for anything but undef? Maybe put in an assert?
There was a problem hiding this comment.
I think currently not. This is the safe default (in case we add another SILValue kind in the future)
There was a problem hiding this comment.
Yes, but we won't know to update this code when someone adds something new. They won't be able to know to make the decision. With the assert, when someone adds the new SILValue, they get a hard warning that they may need to update this code.
|
@compnerd I think this is the fix for what you were saying on the lldb bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a crash
https://bugs.swift.org/browse/SR-10580
rdar://problem/50279857