Skip to content

Add a benchmark for bridging String(contentsOfFile:...), now with ava… #24377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Catfish-Man
Copy link
Contributor

#24326, but with availability fixed for tvOS and watchOS (thanks @eeckstein !)

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Catfish-Man Catfish-Man merged commit 320d063 into swiftlang:master Apr 30, 2019
@gottesmm
Copy link
Contributor

@Catfish-Man are the benchmark doctor issues fixed in this PR? There is a memory issue/naming issue from the previous PR. Can you fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants