[5.1 04/24][Diagnostics] Improve missing conformance diagnostics for opaque return #24393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New diagnostic framework can already identify contextual failures related to opaque return types, `RequirementFailure` just needs to get adjusted to identify correct affected declaration and provide tailored diagnostic. Resolves: rdar://problem/49582531 (cherry picked from commit 1f1e8d9)
… expressions are correct (cherry picked from commit caad4a8)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Looks like not all of the projects have been updated to support Swift 5 in source compatibility suite, failures are unrelated to my changes. |
AnnaZaks
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New diagnostic framework can already identify contextual failures
related to opaque return types,
RequirementFailurejust needsto get adjusted to identify correct affected declaration and provide
tailored diagnostic.
Reviewed By: @jckarter
Resolves: rdar://problem/49582531