[ModuleInterface] Look for a prebuilt module by full target name #24402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
jrose-apple
force-pushed
the
playing-the-long-game
branch
2 times, most recently
from
742928c to
87d8596
Compare
|
@swift-ci Please smoke test |
| } else { | ||
| // Hack: deal with prebuilds of modules that still use the target-based | ||
| // names. This code is duplicated from above but there doesn't seem to | ||
| // be a great way to factor it out due to the early return. |
There was a problem hiding this comment.
Would
if (!path)
path = computeFallbackPrebuiltModulePath(scratch)not work?
There was a problem hiding this comment.
…
Yes, it would. I wrote this against a version that didn't check fs::exists when computing the path, and then hastily revised it once I saw that that got in. I'll change it to that.
jrose-apple
force-pushed
the
playing-the-long-game
branch
from
87d8596 to
2818e36
Compare
|
@swift-ci Please smoke test |
Although the default cache location separates by platform, a /combined/ cache is still an interesting idea, and in that case we need to use the full platform names.
jrose-apple
force-pushed
the
playing-the-long-game
branch
from
2818e36 to
b9d59bd
Compare
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 1, 2019
…ftlang#24402) Although the default cache location separates by platform, a /combined/ cache is still an interesting idea, and in that case we need to use the full platform names. (cherry picked from commit 3d16557)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 1, 2019
…ftlang#24402) Although the default cache location separates by platform, a /combined/ cache is still an interesting idea, and in that case we need to use the full platform names. (cherry picked from commit 3d16557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the default cache location separates by platform, a combined cache is still an interesting idea, and in that case we need to use the full platform names.
rdar://problem/50371801