[Constraint solver] Reject trailing closures matching non-closure-parameters #24403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters. Enhance call-argument matching to reject trailing closures that match up with parameters that cannot accept closures at all. Fixes rdar://problem/50362170.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
slavapestov
reviewed
May 1, 2019
|
|
||
| paramTy = paramTy->lookThroughAllOptionalTypes(); | ||
| return paramTy->isTypeParameter() || | ||
| paramTy->is<ArchetypeType>() || |
There was a problem hiding this comment.
How precise do you want to get here? If it has any constraints at all, it can't accept a function value (just like non-Any existentials)
xedin
reviewed
May 2, 2019
| // If there is no suitable last parameter to accept the trailing closure, | ||
| // notify the listener and bail if we need to. | ||
| if (!acceptsTrailingClosure(params[numParams - 1])) { | ||
| if (listener.trailingClosureMismatch(numParams - 1, numArgs - 1)) |
There was a problem hiding this comment.
In the spirit of matchCallArguments used only to match parameters to arguments based on labels and positions, it seems that better place for this logic could be in other overload of matchCallArguments where types are matched, the problem with that though is that we currently don't diagnose missing parameters via new diagnostic framework, that would have made diagnosing trailing closures much easier...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance call-argument matching to reject trailing closures that match up
with parameters that cannot accept closures at all.
Fixes rdar://problem/50362170.