-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[TF] WIP: Removing all instances of #tfop
.
#24425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is missing the utils/build-script-impl changes and utils/build_swift/driver_arguments.py ie:
and
|
@pschuh The only tests that currently fail are:
but I'm not sure why they fail. I also had to add |
@pschuh Nevermind the above problem. I fixed that. I'm currently removing tests using |
Update the hash, and then we can do the swift-ci for this PR. |
I just updated it. |
@swift-ci please test tensorflow clean |
Not sure if the tests are actually running as nothing is showing up on GitHub for me. |
@swift-ci please test tensorflow clean |
@swift-ci please test tensorflow |
@swift-ci please test tensorflow clean |
@swift-ci please clean test tensorflow |
@rxwei @pschuh @saeta This is a WIP PR to remove all instances of
#tfop
. It's WIP because I haven't yet run tests locally for these changes (currently compiling from scratch so it may take a while). Also, I assumed the uses of#tfop("tfc.configureGPU")
etc also deprecated and went ahead and removed them.I'll wait for the tests to run and see if anything breaks from the removed functionality that was not already disabled by @pschuh's PRs.