Skip to content

build: don't always load clang/cmark #24429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented May 2, 2019

clang/cmark are only needed for the tools, not for the runtime/SDK
overlay. Do not attempt to configure clang and CMark in the case we do
not build the tools. This is needed to enable the standalone standard
library only builds.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

clang/cmark are only needed for the tools, not for the runtime/SDK
overlay.  Do not attempt to configure clang and CMark in the case we do
not build the tools.  This is needed to enable the standalone standard
library only builds.
@compnerd
Copy link
Member Author

compnerd commented May 2, 2019

CC: @gottesmm @Rostepher @gwynne

@compnerd
Copy link
Member Author

compnerd commented May 2, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2019

Build failed
Swift Test Linux Platform
Git Sha - 816dfe2

@compnerd
Copy link
Member Author

compnerd commented May 2, 2019

@swift-ci please test Linux platform

@Rostepher Rostepher self-requested a review May 3, 2019 00:42
Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@compnerd compnerd merged commit 27a2d7d into swiftlang:master May 3, 2019
@compnerd compnerd deleted the bye-bye-birdie branch May 3, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants