Skip to content

Opaque archetypes specializer: Fix cast of nested types #24436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2019
Merged

Opaque archetypes specializer: Fix cast of nested types #24436

merged 2 commits into from
May 2, 2019

Conversation

aschwaighofer
Copy link
Contributor

No description provided.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer aschwaighofer mentioned this pull request May 2, 2019
Merged
@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2019

Build failed
Swift Test OS X Platform
Git Sha - 1330d12

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2019

Build failed
Swift Test Linux Platform
Git Sha - 1330d12

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2019

Build failed
Swift Test OS X Platform
Git Sha - 1330d12

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2019

Build failed
Swift Test Linux Platform
Git Sha - 1330d12

slavapestov
slavapestov reviewed May 2, 2019
View reviewed changes
lib/SILOptimizer/Transforms/SpecializeOpaqueArchetypes.cpp
opd.get(), argType);
opd.set(cast);
}
opd.set(createCast(apply.getLoc(), opd.get(), argType));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is createCast() equivalent to castValueToABICompatibleType() in include/swift/SILOptimizer/Utils/Local.h?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like it might be. I will fix in a follow-up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor Author

@aschwaighofer aschwaighofer May 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up: I can not use castValueToABICompatibleType because it does only handle tuple aggregates (no structs).

@aschwaighofer aschwaighofer merged commit 3089c86 into swiftlang:master May 2, 2019
@compnerd
Copy link
Member

compnerd commented May 3, 2019 •
edited
Loading

This is breaking the Windows test suite! https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=1972

%ptrsize is not a valid substitution, the test isn't checking what you think. You want CHECK-%target-ptrsize I think.

@aschwaighofer
Copy link
Contributor Author

right, thanks!

@aschwaighofer
Copy link
Contributor Author

#24482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aschwaighofer @swift-ci @compnerd @slavapestov