Skip to content

[CMake] Workaround circular linkage dependency #24439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CMake] Workaround circular linkage dependency #24439

wants to merge 1 commit into from

Conversation

davezarzycki
Copy link
Contributor

@davezarzycki davezarzycki commented May 2, 2019 •
edited
Loading

As of cec1a52 (GitHub #24224), the AST now depends on SIL.

@davezarzycki
[CMake] Workaround circular linkage dependency
88ec845 
As of cec1a52, the AST now depends on
SIL.
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@jrose-apple
Copy link
Contributor

Oops. That's very wrong. @aschwaighofer?

@davezarzycki
Copy link
Contributor Author 

ld.lld: error: undefined symbol: swift::ReplaceOpaqueTypesWithUnderlyingTypes::shouldPerformSubstitution(swift::OpaqueTypeDecl*, swift::SILFunction*)
>>> referenced by Type.cpp:2477 (/home/dave/s/u/swift/lib/AST/Type.cpp:2477)
>>>               Type.cpp.o:(swift::ReplaceOpaqueTypesWithUnderlyingTypes::shouldPerformSubstitution(swift::OpaqueTypeDecl*) const) in archive lib/libswiftAST.a

@davezarzycki davezarzycki requested a review from aschwaighofer May 2, 2019 16:32
@compnerd
Copy link
Member

compnerd commented May 2, 2019

Nice, thanks @davezarzycki - this should probably fix the Windows build too!

@gottesmm
Copy link
Contributor

gottesmm commented May 2, 2019

@davezarzycki I would much rather us not fix the circular dependency, but rather eliminate it.

@aschwaighofer
Copy link
Contributor

I think #24443 should fix the dependency cycle I introduced

@davezarzycki
Copy link
Contributor Author

This has been superseded by #24443

@davezarzycki davezarzycki deleted the cmake_circular_dep_hack branch May 3, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple Awaiting requested review from jrose-apple

@slavapestov slavapestov Awaiting requested review from slavapestov

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davezarzycki @jrose-apple @compnerd @gottesmm @aschwaighofer