Skip to content

[ModuleInterface] Short-circuit module loading for frameworks too #24459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrose-apple
Copy link
Contributor

Follow-up to #23857 that handles frameworks as well. Oops.

Credit to @griotspeak for the branch name.

rdar://problem/50070463

Follow-up to 7969705 that handles frameworks as well. Oops.

rdar://problem/50070463
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

I don't think this can affect LLDB; maybe it's just a flutter?

@swift-ci Please smoke test macOS

Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jrose-apple jrose-apple merged commit f76d2c3 into swiftlang:master May 3, 2019
@jrose-apple jrose-apple deleted the dont-stop-til-you-get-enough branch May 3, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants