Skip to content

[Build System: CMake] Install the apinotes in the 'compiler' install component (5.1 04-24-2019 branch). #24473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rostepher
Copy link
Contributor

Copy of #24419 for the 5.1 branch.

rdar://50390238

@Rostepher Rostepher changed the base branch from master to swift-5.1-branch-04-24-2019 May 3, 2019 07:02
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher Rostepher requested a review from najacque May 3, 2019 19:12
Rostepher added 2 commits May 6, 2019 12:08
…component when compiling for Darwin platforms.

Setting the CMake cache variable SWIFT_INCLUDE_APINOTES to true will override the default behavior and unconditionally create the install targets.

(cherry picked from commit c10b815)
…ry when the apinotes directory is included via SWIFT_INCLUDE_APINOTES.

(cherry picked from commit 83932c5)
@Rostepher Rostepher force-pushed the toolchain-apinotes-5.1-04-24-2019 branch from a69c136 to 4502fa4 Compare May 6, 2019 19:08
@Rostepher Rostepher requested a review from a team as a code owner May 6, 2019 19:08
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2019

Build failed
Swift Test Linux Platform
Git Sha - a69c1366c3bc1cc2c65b5b43aaa45a86e6261ba7

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - a69c1366c3bc1cc2c65b5b43aaa45a86e6261ba7

@Rostepher Rostepher merged commit ef41707 into swiftlang:swift-5.1-branch-04-24-2019 May 7, 2019
@Rostepher Rostepher deleted the toolchain-apinotes-5.1-04-24-2019 branch May 7, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants