ReplaceOpaqueTypesWithUnderlyingTypes: Use resilience expansion instead of inlinable attribute #24478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of inlinable attribute
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux |
slavapestov
reviewed
May 3, 2019
| @@ -2484,9 +2484,18 @@ bool ReplaceOpaqueTypesWithUnderlyingTypes::shouldPerformSubstitution( | |||
|
|
|||
| // Allow replacement of opaque result types of inlineable function regardless | |||
| // of resilience and in which context. | |||
| if (namingDecl->getAttrs().hasAttribute<InlinableAttr>()) { | |||
| return true; | |||
| if (auto *afd = dyn_cast<AbstractFunctionDecl>(namingDecl)) { | |||
There was a problem hiding this comment.
Can you add some tests where either the property itself or just the getter is inlinable?
There was a problem hiding this comment.
There is one. It failed when I had not added the code for abstract storage decl.
There was a problem hiding this comment.
Ah ok. A case you might want to test that the old logic definitely would have missed is an @_alwaysEmitIntoClient decl. These are the same as inlinable except they have different linkage -- but don't have an InlinableAttr.
|
@swit-ci Please test |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.