[test] Add availability guards for tests checking behavioral changes in 5.1 #24496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
Array.init(unsafeUninitializedCapacity:…) back-deploys to the 5.0 stdlib, but the implementation there doesn’t catch buffer reassignment.
lorentey
force-pushed
the
stdlib-version-checks-alt
branch
from
4bc496a to
211aae1
Compare
lorentey
commented
May 4, 2019
| @@ -77,6 +77,8 @@ StringBridgeTests.test("Tagged NSString") { | |||
|
|
|||
| func returnOne<T>(_ t: T) -> Int { return 1 } | |||
| StringBridgeTests.test("Character from NSString") { | |||
| guard #available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) else { return } | |||
lorentey
commented
May 4, 2019
| @@ -572,6 +572,11 @@ ${Suite}.test("${ArrayType}/init(unsafeUninitializedCapacity:...:)/validCount") | |||
| } | |||
|
|
|||
| ${Suite}.test("${ArrayType}/init(unsafeUninitializedCapacity:...:)/reassignBuffer") { | |||
| guard #available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) else { | |||
| // When back-deployed to 5.0, this coding error does not get detected. | |||
There was a problem hiding this comment.
That's… odd. Did I add that check in something that's now part of the ABI? LGTM in any case, thx @lorentey!
There was a problem hiding this comment.
The buffer reassign check wasn't in 5.0's underscored initializer, so code using the new public initializer won't get this check when it's deployed on macOS 10.14.2 / iOS 12.2 etc. I don't think this is a problem; the missing check won't break any working code.
Our ABI back deployment tests detected this change in behavior between the 5.0 and 5.1 stdlibs; the availability guard I added here acknowledges that this was an expected change.
|
@swift-ci test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runtime 9999-availability guards around tests checking for behavioral changes since 5.0.
This is useful in case these tests are deployed with the 5.0 stdlib.
rdar://problem/50150948