Skip to content

build: rename LLVM_COMPONENT_DEPENDS #24508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented May 5, 2019

This is not a target dependency but a target link. Name the parameter
to be less misleading. This also makes the name identical to the LLVM
parameter.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented May 5, 2019

CC: @gottesmm

@compnerd
Copy link
Member Author

compnerd commented May 5, 2019

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented May 5, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - d30c4e3814c2d544c4303c4c8bbbf5c693732455

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2019

Build failed
Swift Test OS X Platform
Git Sha - d30c4e3814c2d544c4303c4c8bbbf5c693732455

This is not a target dependency but a target link.  Name the parameter
to be less misleading.  This also makes the name identical to the LLVM
parameter.
@compnerd
Copy link
Member Author

compnerd commented May 5, 2019

@swift-ci please test

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottesmm gottesmm merged commit 4d4d6f6 into swiftlang:master May 6, 2019
@compnerd compnerd deleted the matchy-matchy branch May 6, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants