[benchmark] Fix Existential.Array.Mutating Setup Overhead #24513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mask the setup overhead from copying of existential array in
Existential.Array.Mutating
by increasing the workload (5x). This way the overhead of copying is less than 5%.Remove the misguided attempt at solving this problem with
grabArray
method - there is no way to avoid this overhead because every sample should start from a fresh copy.Note: these benchmarks are tagged
.skip
, so they will not show up in the report.