[5.1-04-24-2019][Reflection] Switch Remote Mirror back to uintptr_t for pointers on watchOS. #24532
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
I would be happy to approve this but it would be good to get someone who knows the remote mirror code to review it. Maybe @slavapestov or @dcci? |
|
(although it's a little sad we have to play these tricks). |
…atchOS. Existing Remote Mirror dylibs are compiled this way, and changing it breaks binary compatibility. We want to use uint64_t everywhere else, since the target's pointer size may not match ours. rdar://problem/50279443
mikeash
force-pushed
the
remote-mirror-watchos-pointer-size-fix-5.1-04-24-2019
branch
from
0faceee to
941fdd3
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
…Availability.h. While we're in there, make SwiftReflectionTest's debugLog function take an @autoclosure so we don't waste a ton of time constructing log messages that are never logged.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Cherry-pick #24529 for 5.1-04-024-2019.
Existing Remote Mirror dylibs are compiled this way, and changing it breaks binary compatibility. We want to use uint64_t everywhere else, since the target's pointer size may not match ours.
rdar://problem/50279443