[android] Enable some tests that should pass on Android. #24550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are limited to only Linux, when they should also pass for Android. Additionally, InputStream.swift.gyb was disabled for Android ARMv7, but wasn't for Android AArch64, which allow me to find the error on it and fix it on swiftlang#24521. Finally, StringLowercasedUppercased is interesting in Android because it checks the used ICU is correct for performing the tasks that the stdlib needs.
|
@swift-ci please test |
compnerd
reviewed
May 7, 2019
| @@ -5,7 +5,7 @@ | |||
| // directly. It is not specific to Linux, it is just that on | |||
| // Apple platforms we are using the NSString bridge right now. | |||
|
|
|||
| // REQUIRES: OS=linux-gnu | |||
| // REQUIRES-ANY: OS=linux-gnu, OS=linux-android, OS=linux-androideabi | |||
There was a problem hiding this comment.
Nifty! I didn't know about REQUIRES-ANY.
compnerd
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are limited to only Linux, when they should also pass for
Android.
Additionally, InputStream.swift.gyb was disabled for Android ARMv7, but
wasn't for Android AArch64, which allow me to find the error on it and
fix it on #24521.
Finally, StringLowercasedUppercased is interesting in Android because it
checks the used ICU is correct for performing the tasks that the stdlib
needs.