[stdlib] Fix and Improve Unit Tests for Set #24575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systematically test also set algebra: * with empty sets on both sides * inverse operation
Really test the Sequence variants of set algebra and cover the same cases as Set.Set.
|
@swift-ci please test |
lorentey
approved these changes
May 8, 2019
palimondo
commented
May 9, 2019
Use explicit type annotation to make it crystal clear (beyoud any reasonable doubt) these are indeed testing the Sequence variants.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzing how well the #21300 handles
isEmptycases, I've noticed that the unit test that should be testingSet.Sequencevariants of methods:isSubsetisSuperSetisStrictSubsetisStrictSuperSetcontained errors (sometimes testing
Set.Setvariants) and the tests did not fully cover the potential edge cases which might arise when implementing performance optimizations for the empty cases.This PR fixes these errors and adds equivalent coverage for both
Set.SetandSet.Sequencevariants.