Skip to content

[ConstraintSystem] Detect and diagnose extraneous returns from void f… #24587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2019
Merged

[ConstraintSystem] Detect and diagnose extraneous returns from void f… #24587

merged 1 commit into from
May 7, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 7, 2019

…unctions

Diagnose an attempt return something from a function which
doesn't have a return type specified e.g.

func foo() { return 42 }

@xedin
[ConstraintSystem] Detect and diagnose extraneous returns from void f…
4f63c4a 
…unctions

Diagnose an attempt return something from a function which
doesn't have a return type specified e.g.

```swift
func foo() { return 42 }
```
@xedin
Copy link
Contributor Author

xedin commented May 7, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 7, 2019

While working on expanding use of insert explicit call fix found out that we don't diagnose extraneous returns via new diagnostics framework yet (which is prerequisite for diagnosing more missing calls).

@xedin xedin merged commit 49710ab into swiftlang:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xedin