Skip to content

[5.1] SR-10555 foreignCopyUTF8 should do bulk access #24648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented May 9, 2019

Cherry picking this to 5.1, ~2.5x speedup for foreign strings

Fixes rdar://50220164

@Catfish-Man Catfish-Man requested a review from airspeedswift May 9, 2019 20:57
@Catfish-Man Catfish-Man self-assigned this May 9, 2019
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man Catfish-Man changed the title SR-10555 foreignCopyUTF8 should do bulk access [5.1] SR-10555 foreignCopyUTF8 should do bulk access May 9, 2019
@swift-ci
Copy link
Contributor

swift-ci commented May 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - 467c499

@Catfish-Man
Copy link
Contributor Author

Original PR: #24289

@Catfish-Man
Copy link
Contributor Author

Additional test coverage in #24874

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man Catfish-Man merged commit 316fcf0 into swiftlang:swift-5.1-branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants