Skip to content

[AliasAnalysis] Check for nullptr before dereferencing. #24657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2019
Merged

[AliasAnalysis] Check for nullptr before dereferencing. #24657

merged 1 commit into from
May 10, 2019

Conversation

dcci
Copy link
Member

@dcci dcci commented May 9, 2019

Fixes an undefined behaviour sanitizer bug.

rdar://problem/50641097

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

[AliasAnalysis] Check for nullptr before dereferencing.
642f64f 
Fixes an undefined behaviour sanitizer bug.

<rdar://problem/50641097>
@dcci dcci requested review from gottesmm, eeckstein and bob-wilson May 9, 2019 22:51
@dcci
Copy link
Member Author

dcci commented May 9, 2019

I'm seeing this on the lldb UBSAN bot.

@dcci
Copy link
Member Author

dcci commented May 9, 2019

@swift-ci smoke test

@dcci
Copy link
Member Author

dcci commented May 9, 2019

uban error for archeology:

14:47:15 /Users/buildnode/jenkins/workspace/oss-lldb-asan-osx/swift/lib/SILOptimizer/Analysis/AliasAnalysis.cpp:585:44: runtime error: reference binding to null pointer of type 'const swift::SILFunction'
14:47:15 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/buildnode/jenkins/workspace/oss-lldb-asan-osx/swift/lib/SILOptimizer/Analysis/AliasAnalysis.cpp:585:44 in 
14:47:15 Stack dump:

eeckstein
eeckstein approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@dcci dcci merged commit dc6b2e2 into swiftlang:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@bob-wilson bob-wilson Awaiting requested review from bob-wilson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcci @eeckstein