Configure XCTest for Dispatch if included in Foundation on Linux #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gribozavr Would it be possible to get a review of this - if your happy with it I'll do the work to update for the merge conflict. Note that the counterpart in XCTest is already merged. |
seabaylea
force-pushed
the
dispatch-xctest
branch
from
5b634b2 to
7e74200
Compare
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
When libdispatch is added into the builds on Linux (for use by Foundation), there are subsequent build errors in XCTest as it needs access to build artefacts from libdispatch due to the downward dependency from Foundation. These changes pass the source and build locations through to XCTest if libdispatch is included in the builds.
The XCTest PR that picks up and uses the arguments has been merged already:
swiftlang/swift-corelibs-xctest#107
Resolved bug number: (SR-)
N/A
!-- This selection should only be completed by Swift admin -->
Before merging this pull request to apple/swift repository: