SR-10241 Consolidate StringInterpolationExpr to StringLiteralExpr in Syntax #24718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
swiftlang/swift-syntax#123 |
rintaro
requested changes
May 13, 2019
Fix incorrect indent
kitasuke
force-pushed
the
SR-10241_string_literal
branch
from
3c08fdd to
e09a341
Compare
|
Thank you for your feedbacks again! Addressed them now. |
|
swiftlang/swift-syntax#123 |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidate StringInterpolationExpr to StringLiteralExpr in syntax tree to provide a way to distinguish quotes and string. See more details in the ticket below.
StringInterpolationSegmentstoStringLiteralSegmentsStringInterpolationExprtoStringLiteralExprTicket
Resolves SR-10241.
Dependency
This PR for SwiftSyntax is also required to apply this change.
swiftlang/swift-syntax#123