Skip to content

test: make test paths more portable #24755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

compnerd
Copy link
Member

Windows uses \ as the separator rather than /. Adjust the tests for
this.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Windows uses `\` as the separator rather than `/`.  Adjust the tests for
this.
@compnerd
Copy link
Member Author

CC: @harlanhaskins @jrose-apple

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please thank you.

(Wanted: a Windows PR smoke test bot.)

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

Haha, yes, that would be nice. We just got a CI bot! So, perhaps dreams to come true :-D

@compnerd compnerd merged commit 9cb2e6e into swiftlang:master May 14, 2019
@compnerd compnerd deleted the unparseable branch May 14, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants