[AutoDiff] Parameter indices data structure overhaul #24761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow Linux |
3 similar comments
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
4 similar comments
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci Please test tensorflow linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
AutoDiffIndexSubsetThis PR overhauls data structures used for parameter indices in the AutoDiff infrastructure in SIL.
Previously, we used
llvm::SmallBitVectorto represent differentiation parameter indices in both AST and SIL. It was not efficient, and most importantly there's no way to put this in an instruction without causing memory leaks.This change replaces all uses of
llvm::SmallBitVectorin SIL AutoDiff code paths with aASTContext-uniquedAutoDiffIndexSubset *where bits are stored as trailing objects.AutoDiffIndexSubsetdoes not have "parameter indices" in its name because it is not only designed for parameter indices, but also for result indices as we move to supporting multi-result differentiation.AutoDiffIndexSubsethas set operations likeisSubsetOf,isSupersetOf, andcontains, but it also has a special capacity property. All differentiable function's parameter indices data should store the number of parameters as capacity, so that the differentiation transform won't need special logic to check whether an index is out of range.Another minor change is the module format layout of
SILDifferentiableAttr. It used to store parameter indices as consecutiveboolbits, but now stores numeric parameter indices directly for efficiency.It will be necessary to refactor or eliminate
AutoDiffParameterIndicesto make use ofAutoDiffIndexSubset.AutoDiffParameterIndicesis at the AST level, so it is not in the scope for this PR.Unblocks #23482. Partially resolves TF-67.