Skip to content

[SIL] Fix [differentiable] where clause parsing. #24762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

[SIL] Fix [differentiable] where clause parsing. #24762

merged 1 commit into from
May 14, 2019

Conversation

dan-zheng
Copy link
Contributor

Parse where clause before closing ].
This fixes parsing canonical SIL files:

# foo.swift: program containing `[differentiable]` attribute.
$ swiftc -emit-sil foo.swift
$ swift foo.sil # now works

@dan-zheng
[SIL] Fix [differentiable] where clause parsing.
5598d39 
Parse where clause before closing `]`.
This fixes parsing canonical SIL files.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label May 14, 2019
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng dan-zheng merged commit b30b6c4 into swiftlang:tensorflow May 14, 2019
dan-zheng added a commit to dan-zheng/swift that referenced this pull request May 15, 2019
@dan-zheng
[ParseSIL] Fix [differentiable] attribute where clause parsing.
4919610 
Follow-up to swiftlang#24762.

Fix `test/AutoDiff/differentiable_sil_attr.sil` to actually test
where clause parsing.

Fix SIL requirement parsing.
Friend PR to master: swiftlang#24790
@dan-zheng dan-zheng mentioned this pull request May 15, 2019
Merged
dan-zheng added a commit that referenced this pull request May 15, 2019
@dan-zheng
[ParseSIL] Fix [differentiable] attribute where clause parsing. (#2…
f64718d 
…4792)

Follow-up to #24762.

Fix `test/AutoDiff/differentiable_sil_attr.sil` to actually test
where clause parsing.

Fix SIL requirement parsing.
Friend PR to master: #24790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

Assignees
No one assigned
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-zheng @rxwei