Add AccessEnforcementOpts fast paths. #24773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
When there is nothing that can be merged, there's no point doing an extra CFG analysis.
1. During identifyAccess, determine if there are either any identical accesses or an accesses that aren't already marked no_nested_storage. If there are neither, then skip the subsequent data flow analysis. 2. In the new StorageSet, indicate whether identical storage was seen elsewhere in the function. During dataflow, only add an access to the out-of-scope access set if was marked as having identical storage with another access. 3. During data flow, don't track in scope conflicts for instructions already marked [no_nested_conflict].
|
@swift-ci test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AccessEnforcementOpts fast paths.
During identifyAccess, determine if there are either any
identical accesses or an accesses that aren't already marked
no_nested_storage. If there are neither, then skip the subsequent
data flow analysis.
In the new StorageSet, indicate whether identical storage was
seen elsewhere in the function. During dataflow, only add an access
to the out-of-scope access set if was marked as having identical
storage with another access.
During data flow, don't track in scope conflicts for
instructions already marked [no_nested_conflict].
0d9ebae