[ConstraintSystem] Detect and diagnose conversion failures related to… #24791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #24754 |
… collection element types
Detect and diagnose a contextual mismatch between expected
collection element type and the one provided (e.g. source
of the assignment or argument to a call) e.g.:
```swift
let _: [Int] = ["hello"]
func foo(_: [Int]) {}
foo(["hello"])
```
xedin
force-pushed
the
diag-collection-element-conversions
branch
from
c1da131 to
b9a0ca6
Compare
DougGregor
approved these changes
May 15, 2019
| @@ -26,7 +26,7 @@ func arraySameType() { | |||
|
|
|||
| let _: SameType = [works] | |||
| let _: SameType = [fails] | |||
| // expected-error@-1 {{value of type '[Fails]' does not conform to specified type 'SameType'}} | |||
| // expected-error@-1 {{cannot convert value of type 'Fails' to expected element type 'Works'}} | |||
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… collection element types
Detect and diagnose a contextual mismatch between expected
collection element type and the one provided (e.g. source
of the assignment or argument to a call) e.g.:
Resolves: rdar://problem/33914447