Skip to content

[SIL Optimization] Add a mandatory optimization pass for optimizing the new os log APIs based on string interpolation. #24796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019

Conversation

ravikandhadai
Copy link
Contributor

This fixes the PR: #24336 that was merged but later reverted as it failed in '--debug-swift-stdlib' mode. This PR fixes the error by making a small change to the implementation in the overlay in file: OSLogMessage.swift.

the new os log APIs based on string interpolation.
@ravikandhadai
Copy link
Contributor Author

@swift-ci Please test and merge

@ravikandhadai
Copy link
Contributor Author

@swift-ci Please test macOS platform and merge

@ravikandhadai
Copy link
Contributor Author

@swift-ci Please test macOS Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9be4fef

@ravikandhadai
Copy link
Contributor Author

@swift-ci Please clean test macOS Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9be4fef

@ravikandhadai
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit aa6827a into swiftlang:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants