Skip to content

[5.1] Warn when using '@_implementationOnly' inconsistently in a module #24828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrose-apple
Copy link
Contributor

Cherry-pick of #24800 to the 5.1 branch. Reviewed by @brentdax.

rdar://problem/50748157

…iftlang#24800)

I thought it would be useful to allow some uses of a module to be
'@_implementationOnly' and others to not be in case someone wanted to
change from one to the other gradually, but it turns out that if
you're trying to /make/ an import implementation-only, you want to
know everywhere you used it.

rdar://problem/50748157
(cherry picked from commit 9647483)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple jrose-apple merged commit c2ecb87 into swiftlang:swift-5.1-branch May 16, 2019
@jrose-apple jrose-apple deleted the 5.1-give-us-this-day-our-daily-mask branch May 16, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant