SILCombine: fix a miscompile in dead alloc_existential_box removal #24835
Conversation
|
@swift-ci test |
| // CHECK-NEXT: release_value [[T]] | ||
| // CHECK-NEXT: tuple | ||
| // CHECK-NEXT: return | ||
| sil @insert_compensating_release_at_release_of_box : $@convention(method) (@in_guaranteed Array<Error>) -> () { |
There was a problem hiding this comment.
Question. Is there an interpreter test that you can make for this as well? Was there a reduced test case that you had?
There was a problem hiding this comment.
Yes I have one. I'll add it.
| // is going away so we need to release the stored value. | ||
| // Note that it's important that the release is inserted at the single | ||
| // release of the box and not at the store, because a balancing retain could | ||
| // be _after_ the store, e.g. |
There was a problem hiding this comment.
You should be a colon after this. Also can you make Note in all capital letters? Something like this:
Release the value that was stored into the existential box. The box
is going away, so we need to release the stored value.
NOTE: It is important that the release is inserted at the single release of the box and /not/ at the store since a balancing retain could be after the store, e.g.:
There was a problem hiding this comment.
thanks, I'll change it
The miscompile results in a use-after-free crash. rdar://problem/50759056
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
The miscompile results in a use-after-free crash.
rdar://problem/50759056