Skip to content

[TF-504] Remove irrelevant fields in _ExecutionContext #24861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2019
Merged

[TF-504] Remove irrelevant fields in _ExecutionContext #24861

merged 4 commits into from
May 18, 2019

Conversation

burmako
Copy link

@burmako burmako commented May 17, 2019

This PR fixes https://bugs.swift.org/browse/TF-505 by removing the only unused field in _ExecutionContext, namely: loadedPrograms. Unraveling that thread revealed TFEState and _TensorComputation which were unused as well. Also, per chat with @bgogul, I removed all deprecated_gpe_mode tests.

@burmako burmako added the tensorflow This is for "tensorflow" branch PRs. label May 17, 2019
@burmako burmako requested a review from bgogul May 17, 2019 18:52
@burmako
Copy link
Author

burmako commented May 17, 2019

@swift-ci Please test tensorflow

1 similar comment
@burmako
Copy link
Author

burmako commented May 17, 2019

@swift-ci Please test tensorflow

Copy link
Contributor

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eugene!

@burmako
Copy link
Author

burmako commented May 17, 2019

@swift-ci Please test tensorflow

2 similar comments
@burmako
Copy link
Author

burmako commented May 17, 2019

@swift-ci Please test tensorflow

@burmako
Copy link
Author

burmako commented May 18, 2019

@swift-ci Please test tensorflow

@burmako
Copy link
Author

burmako commented May 18, 2019

@swift-ci Please clean test tensorflow linux CPU

@rxwei
Copy link
Contributor

rxwei commented May 18, 2019

@swift-ci please test tensorflow

@burmako burmako merged commit f0e8864 into swiftlang:tensorflow May 18, 2019
@burmako burmako deleted the fix/504 branch May 18, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants