Skip to content

[5.1-04-24-2019][Test] Fix backtrace.swift to use %target-run. #24866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[5.1-04-24-2019][Test] Fix backtrace.swift to use %target-run. #24866

wants to merge 2 commits into from

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 17, 2019

Cherry-pick #24864 to 5.1-04-24-2019.

rdar://problem/50863395

@mikeash mikeash requested a review from a team as a code owner May 17, 2019 19:15
@mikeash
Copy link
Contributor Author

mikeash commented May 17, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8c5cddcc1fdf35d44a7be328a5a42e45a4c6ed73

jrose-apple
jrose-apple reviewed May 17, 2019
View reviewed changes
test/Runtime/backtrace.swift Outdated
@@ -1,6 +1,6 @@
// RUN: %empty-directory(%t)
// RUN: %target-build-swift %s -o %t/a.out
// RUN: not --crash %t/a.out 2>&1 | %{python} %utils/backtrace-check
// RUN: not --crash %target-run %t/a.out 2>&1 | %{python} %utils/backtrace-check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've seen problems elsewhere with not --crash + %target-run since the runner doesn't crash. Check out test/PlaygroundTransform/Inputs/not.py.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks for the pointer. I'll rework it.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8c5cddcc1fdf35d44a7be328a5a42e45a4c6ed73

@mikeash
Copy link
Contributor Author

mikeash commented May 20, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8c5cddcc1fdf35d44a7be328a5a42e45a4c6ed73

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8c5cddcc1fdf35d44a7be328a5a42e45a4c6ed73

@mikeash
Copy link
Contributor Author

mikeash commented May 21, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@mikeash
Copy link
Contributor Author

mikeash commented May 21, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@mikeash mikeash force-pushed the backtrace-target-run-fix-5.1-04-24-2019 branch from 6592f35 to 1583281 Compare May 22, 2019 01:54
@mikeash
Copy link
Contributor Author

mikeash commented May 22, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6592f358717066ec554a4a703ef7727a9a4610f8

@mikeash mikeash force-pushed the backtrace-target-run-fix-5.1-04-24-2019 branch from 1583281 to a10c790 Compare May 22, 2019 14:37
@mikeash
Copy link
Contributor Author

mikeash commented May 22, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1583281dc96adb63876f32247e7f43750be505ad

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1583281dc96adb63876f32247e7f43750be505ad

@mikeash mikeash force-pushed the backtrace-target-run-fix-5.1-04-24-2019 branch from a10c790 to ec898a8 Compare May 24, 2019 16:13
@mikeash
Copy link
Contributor Author

mikeash commented May 24, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ec898a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ec898a8

@mikeash
Copy link
Contributor Author

mikeash commented Jul 2, 2019

We didn't end up needing this change on this branch.

@mikeash mikeash closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeash @swift-ci @jrose-apple