Skip to content

[ConstraintSystem] Use missing conformance fix to diagnose contextual failures #24873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 17, 2019

Extend use of missing protocol conformance fix to cover contextual
failures, such as:

  • Assignment mismatches, where destination requires source to conform
    to certain protocol (or protocol composition);
  • Incorrect returns where returned type doesn't conform to the
    protocol specified in the signature.
  • Sequence element type mismatches in condition of for ... in <expr> loop.

xedin added 4 commits May 17, 2019 12:52
… protocol type

Switch type allows "missing conformance" diagnostic to be
used not only for protocols by for protocol compositions as well.
…al failures

Extend use of `missing protocol conformance` fix to cover contextual
failures, such as:

- Assignment mismatches, where destination requires source to conform
  to certain protocol (or protocol composition);
- Incorrect returns where returned type doesn't conform to the
  protocol specified in the signature.
@xedin xedin changed the title Diag missing contextual conformances fixed [ConstraintSystem] Use missing conformance fix to diagnose contextual failures May 17, 2019
@xedin
Copy link
Contributor Author

xedin commented May 17, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 17, 2019

@swift-ci please test source compatibility

@xedin xedin merged commit 5467232 into swiftlang:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant