[AutoDiff] [Sema] Infer Differentiable conformance for @differentiable function parameters and results. #24896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
changed the title
…function parameters and results.
Extend generic requirement inference to infer `Differentiable` protocol conformances from parameters and results that have a `@differentiable` function type. For each `@differentiable` function type, require its non-`@nondiff` parameter types and result to conform to `Differentiable`.
A common pattern in libraries like this
```swift
func foo<T: Differentiable, U: Differentiable, V: Differentiable>(
_ f: @differentiable (T, U) -> U
)
```
... is now simplfied to just the following:
```swift
func foo<T, U, V>(_ f: @differentiable (T, U) -> V)
// Inferred requirements: `where T: Differentiable, U: Differentiable, V: Differentiable`
```
Resolves [TF-512](https://bugs.swift.org/browse/TF-512).
|
@swift-ci please test tensorflow |
|
The broken test is a dynamic callable regression from merge that's not reproducible on macOS, unrelated to this patch. |
|
Hey @rxwei! This is an awesome simplification. I like it very much. Just wanted to check: can we have some tests ensure that everything works correctly if you do still specify |
|
@saeta Those tests exist in the same file where I added new tests, and all other differentiation test files do still specify the conformances explicitly since they are unchanged. |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Nov 25, 2019
…erentiable(linear)' parameters or results. Update `GenericSignatureBuilder` to match the behavior specified in the manifesto: https://github.com/apple/swift/blob/master/docs/DifferentiableProgramming.md#implied-generic-constraints Previously, swiftlang#24896 added support for implied `Differentiable` constraints from `@differentiable` parameters or results.
rxwei
added a commit
that referenced
this pull request
Nov 25, 2019
…erentiable(linear)' parameters or results. (#28472) Update `GenericSignatureBuilder` to match the behavior specified in the manifesto: https://github.com/apple/swift/blob/master/docs/DifferentiableProgramming.md#implied-generic-constraints Previously, #24896 added support for implied `Differentiable` constraints from `@differentiable` parameters or results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend generic requirement inference to infer
Differentiableprotocol conformances from parameters and results that have a@differentiablefunction type. For each@differentiablefunction type, require its non-@nondiffparameter types and result to conform toDifferentiable.A common pattern in libraries like this
... is now simplfied to just the following:
Resolves TF-512.