Skip to content

[5.1] Allow inheritance from resilient classes with missing members #24914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

beccadax
Copy link
Contributor

Cherry-picks #24881 to swift-5.1-branch. Reviewed on master by @jrose-apple; @slavapestov has also seen it, but I don't know how thoroughly he reviewed it.

When a class has missing vtable entries, we don’t allow it to be subclassed. This is unnecessarily restrictive for resilient classes, and @_implementationOnly imports now make missing vtable entries much more common. This PR carves out an exception to that rule for resilient classes.

Fixes rdar://problem/50902125.

…den-method

Allow inheritance from resilient classes with missing members
@beccadax
Copy link
Contributor Author

@swift-ci please test

@beccadax beccadax changed the title Allow inheritance from resilient classes with missing members [5.1] Allow inheritance from resilient classes with missing members May 20, 2019
@beccadax beccadax merged commit 911cd53 into swiftlang:swift-5.1-branch May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant